T3 framework v2.7.3 has an error when used with PHP 7.3.0.

pvalsecc

The browser cannot decode my pages because the following is inserted at the beginning (before the html tag) of them:

<b>Warning</b>:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in <b>.../plugins/system/t3/includes/menu/megamenu.php</b> on line <b>141</b><br />

If I change the continue into a continue 2 everything works.

pavit

Hi pvalsecc

Could you share your website url ? so we can test it also ?

Regards

denradford-gmail-com

I too encountered this error after updating PHP to 7.3 with menu/megamenu.php as well as menu/t3bootstrap.php

php 7.3 related errors where using continue inside a switch raises a PHP warning. Either use continue 2 or break. Previously continue behaves like break but the intended usage is to continue the for loop instead.

Therefore the scripts need to be updated depending on the desired chosen behavior.
Considering these scripts were written pre-php73 and also noting that the line directly above continue; in both cases is this comment: // No further action needed. I believe continue; may need to be changed to break; in both instances. I have preemptively replaced all instances of continue; with break; for both files. This resolves the two errors encountered on the home page. My site is running Joomla with Purity III template with T3 plugin.

megamenu.php has 4 instances of continue;
Line 72 78 141 308
t3bootstrap.php has 1 instance
Line 88
but it looks like all t3 files will need to be combed to ensure compatibility with php 7.3
e.g. plugins/system/t3/includes/core/template.php has 9 instances of continue;
Den

denradford-gmail-com

Only moments later I encountered the same error numerous times attempting to load and use ThemeMagic.
Doing a search and replace within t3/includes/lessphp/less/less.php changing all instances of continue; to break; so far results in error free loading and running of ThemeMagic.

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9386

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9394

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9399

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9405

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9415

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9418

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9438

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9443

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9464

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /usr/local/www/apache24/data/plugins/system/t3/includes/lessphp/less/less.php on line 9471

teitbite

denradford-gmail-com Hi. This is a warning connected to changes in PHP codding standards. Our products will soon be updated to work with it, meanwhile please disable showing errors in joomla global configuration and/or in php.ini file. This has no effect on functionality.

denradford-gmail-com

teitbite

I changed in Joomla Admin -> Global Configuration -> Server (tab) -> Error Reporting
from System Default to None

This has silenced the php warnings. Thank you.

teitbite

denradford-gmail-com Hi. This is just a temporary solution. Code will be updated soon.

ideatikanet

Any news on the update? Its been quite a while since it was first reported.

Thanks!

saguaros

ideatikanet

The team is working on this, pls stay tuned.

saguaros

Updated:

It's fixed here:https://github.com/t3framework/t3/issues/542

ceesdu

Hi Saguaros,

That’s to difficult for me, I don’t see what I must do.
Best regards Cees

saguaros

ceesdu
Share me the admin + FTP account of your site in another thread you raised, I will check for you.

vipsattacom

i really a great post i really like your work i am having a problem in my core PHP site :
link : satta king

ceesdu

Hi Saguaros,

[Removed by Mods]

saguaros

ceesdu
Don't add the login info in your reply, it's public.

You can edit Fields in your first post: https://www.joomlart.com/forums/d/21822-php-7-3-can-t-login

ceesdu

Sorry I thougd it was private
saguaros

ceesdu

saguaros

Hi saguaros,

source/plg_system_t3/includes/menu/megamenu.php
@@ -138,7 +138,7 @@ function __construct($menutype = 'mainmenu', $settings = array(), $params = null
case 'separator':
case 'heading':
// No further action needed.
continue;
break;

			case 'url':
				if ((strpos($item->link, 'index.php?') === 0) && (strpos($item->link, 'Itemid=') === false)) {

I have changed that ( Put in: Continue🙂 , without result. I let my site today on PHP 7.3 If you will you can see it.
I send you a screen dump Of the frontpage.

Kindest regards Cees

saguaros

ceesdu
Kindly share the admin + FTP account in the discussion you created here: https://www.joomlart.com/forums/d/21822-php-7-3-can-t-login

I will check it for you.

ceesdu

Hi,

This morning I see that the front page by Google Data High liter have still the same failure, see screendump.

Best regards Cees

ceesdu

It must be this Picture

saguaros

ceesdu

The change here: https://github.com/t3framework/t3/pull/543/files

means that you need to replace the 'continue;' by 'break;'

I updated for you, it should be ok now.

Kindly check.