Frontend Module Edit, layout issue

hammur

Hi,

When editing the JA Image Hotspot module on Frontend using the Inline Edit feature of Joomla, the layout of the settings tab isn't displayed correctly.

Firstly the image preview box is displayed to the right of the Global Configuration settings. It should have been to the right of the Marker Control settings?
Also the settings tab seem to include a random <li>...</li> tag which looks a bit odd, as the other tabs don't have this.

The most concerning issue is that when in the edit page for the JA Image Hotspot module, the right sidebar is pushed down to the bottom of the page. This behaviour only happens with the JA Image Hotspot module, i.e. upon editing any other module the right Sidebar stays in place where it should be.

See attached image.

To replicate try:
- Use Protostar template
- Create a JA Image Hotspot module to Top-centre (position-3)
- In 'System > Global Configuration' set 'Inline Editing' to 'Modules'
- Open the edit page of the module on Frontend

saguaros

Hi hammur

Thanks for your report! I've shared with the team for further checking on this.

Regards

hammur

Hi Saguaros,

Any update on this?

Regards

saguaros

Hi hammur I'm sorry for this lateness, I will get back to you as soon as I got the solution from team.

hammur

Hi again

Another issue I've noticed is that the JA Image Hotspot module does not have any name attribute defined for its legend fields, i.e. the 'Global Configuration' and 'Marker Control' legends in the file 'mod_jaimagehotspot.xml'.

This may cause issue with the Joomla core form field render when editing the module on frontend, especially if using the Advanced Module Manager extension to handle frontend module editing.
The issue can cause many duplications of these legend fields in the Module Edit page.

According Joomla docs Standard form field types, the name attribute is mandatory for all field types.

So I fixed this issue by simply adding a name attribute to the two legends fields where I changed

(line  68)   <field type="legend" label="Global Configuration" icon="icon-options" />
(line 208)   <field type="legend" label="Marker Control" icon="icon-location" />

(line  68)   <field name="global_confiugration" type="legend" label="Global Configuration" icon="icon-options" />
(line 208)   <field name="marker_control" type="legend" label="Marker Control" icon="icon-location" />

Would be nice to have this fixed in a new version, so that my above fix doesn't get overridden again from future updates of the module.

saguaros

hammur

Thanks for your input, I will share with the team for further review also.