error: create_function deprecated in php 7.2

analystguy

Dominic:

After installing WP SuperCache the site did not speed up page loading. If anything it made it worse so I uninstalled the plug in. I never saved the results of the cached pages before removing plugin.

This plugin caused a lot of damage that I am in the process of fixing. The issue I have at the moment is a php error. Notably-
Function create_function() is deprecated in /var/www/html/wp-content/themes/News/gavern/helpers/helpers.layout.php on line 828

I am working from a child theme and this means altering the parent News theme in accordance with the newer php standard.

line 828 of the file reads
$conditional_function = create_function('', 'return '.gk_condition($options_type[$id], $options[$id], $users[$id]).';');

Can you please tell me what this should read?

Thanks.
Dave

dominic

Hi analystguy,
I have checked your site and I can not edit your file.
About this issue, you can open this file and replace it with the following code:
http://snippi.com/s/2jq2p11

analystguy

dominic

I updated the helpers.layout.php file with your code and it absolutely wrecked the entire site. Gone are the menus and css overrides. What a mess!

dominic

Hi analystguy,
I have checked with the localhost and the theme still works fine.
In this case, you can find the line 828 and replace it with the following code:

if( isset($options[$id]) && $options[$id] != '' ) {
	if (version_compare(PHP_VERSION, '7.0.0') >= 0) {
	    //fix bug with php 7.2
		$conditional_string = gk_condition($options_type[$id], $options[$id], $users[$id]);
		// echo $conditional_string;
		$conditional_function = function() use ($conditional_string) { return @eval('return '.$conditional_string . ';'); };
		$conditional_result = $conditional_function();
	}else{
		// create function
		$conditional_function = create_function('', 'return '.gk_condition($options_type[$id], $options[$id], $users[$id]).';');
		// generate the result of function
		$conditional_result = $conditional_function();
	}

	
}

I tried to access your site to help you fix it. However, the site not work for me.

analystguy

dominic

OK thanks. No offence, but the last time you made a change to my site, it took me a while to get it back the way things were. I thought it best if I knew what is being done in advance of it happening. I do, however, appreciate your response.

analystguy

dominic
I made the change to helpers.layout.php as you've laid out. The screen displays ok, but it is preceded by a new error -

Notice: Trying to access array offset on value of type bool in C:\Users\username\Local Sites\eclassactions\app\public\wp-content\themes\News-child\gavern\helpers\helpers.layout.php on line 267

line 267 is in gk_opengraph_metatags() function

265 if($image == '') {
266 $image = wp_get_attachment_image_src( get_post_thumbnail_id( $postID ), 'single-post-thumbnail' );
267 $image = $image[0];
268 }

debug.log shows
[04-Feb-2021 23:03:45 UTC] PHP Notice: Trying to access array offset on value of type bool in C:\Users\username\Local Sites\eclassactions\app\public\wp-content\themes\News-child\gavern\helpers\helpers.layout.php on line 267
[04-Feb-2021 23:03:45 UTC] PHP Stack trace:
[04-Feb-2021 23:03:45 UTC] PHP 1. {main}() C:\Users\username\Local Sites\eclassactions\app\public\index.php:0
[04-Feb-2021 23:03:45 UTC] PHP 2. require() C:\Users\username\Local Sites\eclassactions\app\public\index.php:17
[04-Feb-2021 23:03:45 UTC] PHP 3. require_once() C:\Users\username\Local Sites\eclassactions\app\public\wp-blog-header.php:19
[04-Feb-2021 23:03:45 UTC] PHP 4. include() C:\Users\username\Local Sites\eclassactions\app\public\wp-includes\template-loader.php:106
[04-Feb-2021 23:03:45 UTC] PHP 5. gk_load() C:\Users\username\Local Sites\eclassactions\app\public\wp-content\themes\News-child\page-home.php:11
[04-Feb-2021 23:03:45 UTC] PHP 6. include() C:\Users\username\Local Sites\eclassactions\app\public\wp-content\themes\News-child\gavern\helpers\helpers.layout.php:33
[04-Feb-2021 23:03:45 UTC] PHP 7. do_action() C:\Users\username\Local Sites\eclassactions\app\public\wp-content\themes\News-child\layouts\header-child.php:17
[04-Feb-2021 23:03:45 UTC] PHP 8. WP_Hook->do_action() C:\Users\username\Local Sites\eclassactions\app\public\wp-includes\plugin.php:484
[04-Feb-2021 23:03:45 UTC] PHP 9. WP_Hook->apply_filters() C:\Users\username\Local Sites\eclassactions\app\public\wp-includes\class-wp-hook.php:311
[04-Feb-2021 23:03:45 UTC] PHP 10. gavernwp_metatags_hook() C:\Users\username\Local Sites\eclassactions\app\public\wp-includes\class-wp-hook.php:287
[04-Feb-2021 23:03:45 UTC] PHP 11. gk_opengraph_metatags() C:\Users\username\Local Sites\eclassactions\app\public\wp-content\themes\News\gavern\hooks.php:123

The header-child.php code on line 17 is <?php do_action('gavernwp_metatags'); ?>

Any ideas?

dominic

Hi analystguy,
I have checked and found that this is just Notices about code not issue, warning or bug, you can rest assured about it. It's safe for your site.

In this case, you should open the wp-config.php file then find the following code:
define( 'WP_DEBUG', true );
And replace with the following code:
define( 'WP_DEBUG', false );