Bug: render_class is not displayed

thesdhotel

The product-item.php layout has the syntax {render_class} to display the render_class of custom fields.

However this does not work anymore.

It worked ok in Joomla 3, but seems to be broken in the Joomla 4 version.

Can you please verify? Thanks!

saguaros

thesdhotel Hi

Could you share the credentials of your site eg: URL + super admin account and tell me where you put the class?

thesdhotel

Hello,
No need to give you access.

This can be reproduced in a clean basic Joomla installation with the latest versions of:
ja-megafilter-component_2.0.2
ja-megafilter-content-plugin_1.1.7

It can actually be seen as a problem on Joomla 3 as well.

See screenshots below:

Where the {render_class} is entered in the field

Where the {render_class} is entered in the default file:
plugins/jamegafilter/content/layouts/default/product-item.php

The result in the frontend (No {render_class} is displayed where it should be)

It worked correctly on previous versions, but it must have be broken in some newer version.

Note: It's not just {render_class}, also {label_render_class} also doesn't work

saguaros

thesdhotel We're looking into this issue, could you share the credentials of your site eg: URL + super admin and ftp account so we can check for you?

thesdhotel

WHY? Why do you keep asking for credentials to my site? You don't need them. This can be reproduced on a standard installation of Joomla. You don't need my site to see it, you can see it in your test site the same way.

saguaros

I asked for the info so that when there is update from our dev team, I can update directly for you. If you don't want, it's ok.

thesdhotel

You can send me the link to the updated version here and I can test it 🙂

Thank you 🙂

saguaros

thesdhotel I will update here when having news from team, kindly wait.

thesdhotel

Hello there, any update on this issue?

saguaros

thesdhotel Hello

Our developer is still working on this issue, pls give us more time.

thesdhotel

Hello, still no update? It has been over a month... This issue is preventing me from launching my Joomla 4 sites.

vangogh

Hi, thesdhotel
After debugging, I figured out the reasons. You kindly replace these files then re-index your mega filter and test again.
components/com_jamegafilter/assets/js/main.js
plugins/jamegafilter/content/helper.php

support-render-joomla-custom-fields.zip

14kB

Regards,
Vanhs

saguaros

Hi,

I'm sorry for this lateness, I will remind our developer and get back to you soon.

thesdhotel

Hello @vangogh,

I tested this updated code and I noticed there are issues with your helper.php code, the way you implemented it doesn't seem to be the best approach to fix the issue.

What happens now is that the json file now contains the render classes for ALL the fields assigned to the article, instead of only the fields that are set to be displayed.

The json should contain the render classes only for the fields that are set to be displayed. So only in this case:
if ($this->checkPublished('attr.' . $k . '.value') || $this->checkDisplayOnFO('attr.' . $k . '.value')) {

Just like it's done on line 692 for the ['title'], ['type'], etc.

If you look at the previous version 1.13 of the plugins/jamegafilter/content/, it was actually done that way. Can you simply revert it to the same method used in plugin version 1.13? It was working perfectly.

Let me know.

vangogh

Hi, thesdhotel
Thank you for the suggestion. I will check it.
Regards,
Vanhs

thesdhotel

@vangogh Thanks, please let me know.