Many Bugs Found...

aaronblrt11

I have found several bugs I just wanted to report. First in home.php the after body is listed twice both on line 72 & 131. I believe the 72 is suppose to be before body. And when viewing page source you can see the after body code is loaded twice and the before body code (anything you put in the before/body) does not appear anywhere. Also the Off-Canvas menu always shows, even if you have the visible toggle turned to disable in the backend, the off-canvas menu still displays.
And lastly, there is no option to change the width of the template. You can add body{max-width:1920px;width:100%;} to the custom.css and it does nothing. So the width seems to be hard-coded somewhere and overrides don't work.

dominic

Hi aaronblrt11,
Thank you for your feedback, I sent and notified our technical team, and we will check it.

About the body width, you can use the following CSS code in the custom.css file:

@media (max-width: 1920px) {
  .container, .container-lg, .container-md, .container-sm, .container-xl, .container-xxl {
    max-width: 1440px;
  }
}

Or:

@media (min-width: 1400px) {
  .container, .container-lg, .container-md, .container-sm, .container-xl, .container-xxl {
    max-width: 1440px;
  }
}

We have tested and the CSS code work fine.

aaronblrt11

The template width is hard-coded in the files as I thought after hours of research. You actually have to change in the header and main body php files from container to container-fluid. The above code had zero effect still.

And here is a picture (since I'm running in localhost) of the issue with the off-canvas menu. It stays on always despite being disabled in the template settings. And shows 2 of them on mobile. And only the purple one that shows all the time works.

Also as far as the before body/after body code goes. The line 131 should be changed to before body. I fixed in my default.php file in localhost and it corrected the bug perfectly, now only one after body shows and it properly displays the before body code also.

Just want to help because I di believe in this project and love that GK Framework is so light-weight and not based on useless page builders for those who don't want or use page builders.

dominic

Hi aaronblrt11,
Thank you for the update. We will review it promptly and provide any necessary updates as soon as possible.

carlosdel123

@dominic
@aaronblrt11

Have you found a solution so that the offcanvas menu does not appear twice?
I agree that it seems like a very good template, very fast.

dominic

Hi carlosdel123,
In this case, you can use the following CSS code to hide the button:

.gk-offcanvas-wrapper .btn.btn-primary {
  display: none;
}

We will update this feature in the next version.

aaronblrt11

carlosdel123 Unfortunately I gave up for now until more bugs are fixed by the devs. A lot of things like container vs container fluid are hard-coded (should be a template option) with the php files and requiring editing of the files which may end up overwritten when a new version comes out. These are things that should the available in the settings. There are other issues also like the before /body and after /body bug that I mentioned in another post that is an easy fix but again could be overwritten in an update and if it's overwritten and not fixed then you have to go do all the work again.
I am keeping my eye on GK Framework and watching for updates. But for right now my main site is sticking with Helix Ultimate. But as I said GK Framework seems much faster and if matured properly will be the way to go in the future for Joomla 4 & 5 (depending on how thing go with future Joomla 4 since many sites are stuck due to extreme requirements of J5, the new SQL requirement of 8+ when most shared hosting is still on 5.6 & 5.7 and some aren't planning upgrades.) But I am running GK Framework in my localhost and testing converting my huge site over to it should the bugs get fixed and it matures into a usable product.
And when I use the word mature, I mean growing or regular bug fixes. Currently I see bugs reported 4-5 months ago not fixed. And again they are fixable yourself but if a update overrides your work and doesn't have those bug fixed, then it's more work.

carlosdel123

aaronblrt11

You are absolutely right, it is a shame that it has many errors. The good thing about this template is that it is very lightweight as it does not use a framework like helix or yoothemepro, which are not suitable for very large sites. As for some modifications, you can save a custom.css file for when you have to update it.

dominic

Hi carlosdel123 , aaronblrt11,
We appreciate your interest in our product. Rest assured, we are actively addressing and resolving any issues that arise. Should you encounter any further issues, please don't hesitate to inform us, and we'll ensure they are promptly addressed in the upcoming version.
1/ We will fix the home.php the after body is listed twice both on lines 72 & 131.
Hot Fix:

Line 72, you can change the code with this:
<?php echo GKConfig::get('custom_code_before_body') ?>

2/ I'm currently puzzled by the off-canvas issue. To remove the icon, you'll need to disable the corresponding option across all template styles. My apologies for any inconvenience this may cause.

3/ Presently, the option to customize the container from the backend hasn't been updated. However, for the gk blank using the container variable from the bootstrap you can easily achieve this by customizing the CSS, not the PHP file. Simply add your CSS file to templates/your_template/media/css or you can override the variable in the templates/your_template/media/scss/_variables.scss file, and it will persist through template updates.

Please refer to the following document guide for instructions on customizing the template:
https://www.gavick.com/joomla-templates/gk-framework/install#gk-AddScript-addCss

Let me know if you have new issues/bugs, we will update it now.

aaronblrt11

dominic

Any ETA on an update? I would like to try again in my localhost once the update is out. I'm very interested in the future of this project because it is very lightweight, but it feels like it's a back burner project more than active currently. And what I mean by that is it feels GavickPro isn't getting the full support like Joomlart does.

And please keep this a lightweight project like it is currently. Don't bloat it with huge features. I think the lightweight is what is attracting us to this project but it's still like a beta in it's current state and not ready for live sites yet until the bugs are worked out.

dominic

Hi aaronblrt11,
We've released the latest version of the GK Framework. Please install it and let us know if you have any issues or questions.