top for .t4-sticky from breadcrumbs is for some reason off by 1 pixel to the bottom.
How to get around this? Apart from dirty tricks like setting top with !important manually. Which could get wrong after other changes.
top given to sticky is off by 1 pixel
Hi destroy666,
You can use the following CSS:
#t4-header .container {
border-bottom: 1px solid #333;
} Thanks, no workaround with border works though, it only does if you do it in dev tools. The script initially calculates the top position of the next element based on the entire size of the previous element, including border. And since there's a shadow, I guess that makes it think the element is larger.
Where can I find the script in the template files? Would be the easiest to fix it there
It's declared in this file: /plugins/system/t4/themes/base/js/base.js
6 days later
The fix would be to change:
top += elSk.offsetHeight;
to:
top += elSk.getBoundingClientRect().height;
as offsetHeight doesn't respect floating point pixels and rounds them.
This will get overwritten onupgrades though, right? Where can I report it as a bug/fix?
destroy666 This based file will be overridden when updating new version of T4 framework.
I will share with T4 team for further checking on this.
9 months later
It indeed gets overwritten, which is annoying.
Any progress on fixing it? CanI submit a patch somewhere?