Public Forums 71,145 posts

[korb Friend korbJoin date: March 2008Posts: 315Downloads:0Uploads:0 Thanks: 40 Thanked: 48 times in 39 posts]

#323374

Add a slogan for that menu item, you will see the slogan as the url with Joomla core SEF, and with sh404sef you will see full menu title in the link, like the example I posted above.

Actually this could be related to sh404SEF com_contact sef plugin and Joomla core SEF plugin, as it cannot handle contact menu items properly: instead of adding contact category or contact name to the title, it adds menu item title…

I will investigate this further as I am part of the new sh404SEF development/testing member on Anything Digital.

But we must make menu icons show up with any SEF !

Danny

[korb Friend korbJoin date: March 2008Posts: 315Downloads:0Uploads:0 Thanks: 40 Thanked: 48 times in 39 posts]

#323431

I managed to fix URL error for contact pages and megamenu if sh404sef is on. Anyone interested for this fix, use the file from this post..

[orpheus2510 Friend orpheus2510Join date: July 2007Posts: 149Downloads:0Uploads:1 Thanks: 3 Thanked: 14 times in 1 posts]

#323435

I don’t know wether someone has written it, but there’s is a code mistake in /templates/ja_purity_ii/layouts/blocks/head.php, line 55. Instead of
[php]<link href=”<?php echo $this->templateurl(); ?>/css/ie.php” rel=”stylesheet” type=”text/css” />[/php]it must be
[php]<link href=”<?php echo $this->templateurl(); ?>/css/ie.css” rel=”stylesheet” type=”text/css” />[/php]Otherwise you get 404-messages in the logs, when IE-users visit the page.

Second thing:
The button for frontpage editing ist cut because the text of articles is moved to the left for 10px. A solution could be to add the following lines to the template.css:

div.leading .contentpaneopen_edit {
margin-left: 0px;
}

.contentpaneopen_edit {
margin-left: 10px;
}

1 user says Thank You to orpheus2510 for this useful post

1. korb

[rosensta Friend rosenstaJoin date: May 2007Posts: 36Downloads:0Uploads:5 Thanks: 7 Thanked: 1 times in 1 posts]

#323436

<em>@basskool 152664 wrote:</em><blockquote>I managed to fix URL error for contact pages and megamenu if sh404sef is on. Anyone interested for this fix, use the file from this post..</blockquote>

Nice work – I wish it would work with Joomla SEF as well!!
Maybe the solution, is to make the switch to sh404sef instead…..;)

Cheers,
Rosensta

[marcodeluca Friend marcodelucaJoin date: October 2009Posts: 16Downloads:0Uploads:0]

#323440

The Error:

PHP Fatal error: Call to a member function get() on a non-object in templates/ja_purity_ii/libs/menu/base.class.php on line 149

Updated to the 1.1 Stable, that error still happens when you set a menu item to “registered” and then visit the site as a guest. Here’s the code that causes the problem:

//unset item load module but no content

foreach ($this->items as $v) {
if (($v->megaparams->get(‘modid’) || $v->megaparams->get(‘modname’) || $v->megaparams->get(‘modpos’))
&& !isset($this->children[$v->id]) && (!isset($v->content) || !$v->content)) {
$this->remove_item($this->items[$v->id]);
unset($this->items[$v->id]);
}
}

I cut that right out of the base.class.php and the error goes away. Of course, I know next to nothing about php code, so Im sure cutting that out is like cutting out a body part -( what is that, a spleen )- and hoping you don’t need it.

Im sure if it’s there it does something…maybe someone can tell me what:)

– md

[korb Friend korbJoin date: March 2008Posts: 315Downloads:0Uploads:0 Thanks: 40 Thanked: 48 times in 39 posts]

#323528

<em>@rosensta 152670 wrote:</em><blockquote>Nice work – I wish it would work with Joomla SEF as well!!
Maybe the solution, is to make the switch to sh404sef instead…..;)

Cheers,
Rosensta</blockquote>

Just added a new tracker for this, I almost found something, but I need JA assistance on digging this. This is the last issue I must fix before I launch my new redesigned template out of Purity II.
Watch the tracker here
http://pm.joomlart.com/browse/JATCPURITYII-57
Danny

2 users say Thank You to korb for this useful post

1. Arvind Chauhan
2. rosensta

[rosensta Friend rosenstaJoin date: May 2007Posts: 36Downloads:0Uploads:5 Thanks: 7 Thanked: 1 times in 1 posts]

#323540

Same for me – after this fix, I’ll start using the template publicly as well!
Thanx for your effort on this – I really appreciate it!!!

Cheers,
Rosensta

[rosensta Friend rosenstaJoin date: May 2007Posts: 36Downloads:0Uploads:5 Thanks: 7 Thanked: 1 times in 1 posts]

#323548

BTW Danny – maybe it’s worth mentioning in the tracker, that the icon-issue is only present with Megamenu? (as far as I see it..)

Cheers,
Rosensta:)

[korb Friend korbJoin date: March 2008Posts: 315Downloads:0Uploads:0 Thanks: 40 Thanked: 48 times in 39 posts]

#323549

The issue is present on all menu types with sh404SEF. I don’t know why, when sef is on, for some icons the path is /root/images/img-name.jpg and this is a visible icon, but for others I see path images/img-name.jpg , an invisible icon (same path will show a visible image with SEF OFF).

I think the module template overide could be the problem I will keep in touch with my findings.
Danny

[burek Friend burekJoin date: February 2007Posts: 3Downloads:0Uploads:0]

#323568

Hi,

So far, I’ve found this bug in several templates, so it could be a mistake that has been copy/pasted to most templates..

Anyway.. When content articles have quotation mark in the title, the “Read more” button in the front page (blog layout), creates A tag with title attribute that contains value with double quotations, for example, let’s say we have a content item titled
“This is a title that contains quotations”
now, if we refrewsh the front page, we will see that “Read more” button looks something like this:

<a href="..." title=""This is a title that contains quotations"">...</a>

(notice that title attribute is invalid, because it contains double quotations).

As far as I’ve checked, the error is most probably located in these files:
template_name/html/com_content/category/blog_item.php
template_name/html/com_content/frontpage/default_item.php
template_name/html/com_content/section/blog_item.php
because they contain the code like this:

<a href="..." title="<?php echo $this->escape($this->item->title); ?>" ... >...</a>

which should look like this:

<a href="..." title="<?php echo htmlspecialchars($this->escape($this->item->title)); ?>" ... >...</a>

I hope you get the point..

Cheers 🙂

[burek Friend burekJoin date: February 2007Posts: 3Downloads:0Uploads:0]

#323572

Found in template: “JA_Nagya”

Affected files:
/html/com_content/article/default.php
/html/com_content/category/blog_item.php
/html/com_content/frontpage/default_item.php
/html/com_content/section/blog_item.php

Affected code:

<span class="article-section">
<?php if ($this->item->params->get('link_category')) : ?>
<?php echo '<a href="'.JRoute::_(ContentHelperRoute::getCategoryRoute($this->item->catslug, $this->item->sectionid)).'">'; ?>
<?php endif; ?>
<?php echo $this->item->category; ?>
<?php if ($this->item->params->get('link_section')) : ?>
<?php echo '</a>'; ?>
<?php endif; ?>
</span>


openning and closing of <a> tag should be handled by both:

if ($this->item->params->get('link_category'))

but, openning tag is handled with “link_category'” in the if statement, and closing tag is handled with “link_section” in the if statement, which causes invalid html output, for example, missing closing </a> tag when an article is displayed in a category layout.

[korb Friend korbJoin date: March 2008Posts: 315Downloads:0Uploads:0 Thanks: 40 Thanked: 48 times in 39 posts]

#323573

I get the point, but my JA Purity install shows me right ttles, with no 2quotes, maybe because I use sh404sef? but I don;t think it has anythin to do with sef comp. Maybe old templates behave bad on a new Joomla version.

[burek Friend burekJoin date: February 2007Posts: 3Downloads:0Uploads:0]

#323574

oh gosh.. i’ve posted these 2 bugs in a wrong place i guess.. sorry :/

anyway, the first bug i’ve reported is found at least in 2 joomla art templates: ja_purity (v1.2.0) and ja_nagya(v1.0) (also freelance_plazza v1.0.1)

the second bug is only present in ja_nagya (v1.0)

edit: i don’t use any sefs

[korb Friend korbJoin date: March 2008Posts: 315Downloads:0Uploads:0 Thanks: 40 Thanked: 48 times in 39 posts]

#323613

I finally found the fix for this issue. The issue is reported here http://pm.joomlart.com/browse/JATCPURITYII-57

open libs/menu/base.class.php

FIND LINE


$itembg = 'style="background-image:url(images/stories/'.$iParams->get('menu_image').');"';

REPLACE WITH


$itembg = 'style="background-image:url('.JURI::base().'images/stories/'.$iParams->get('menu_image').');"';


AND LINE


$txt = '<span class="menu-image"><img src="images/stories/'.$iParams->get('menu_image').'" alt="'.$tmp->name.'" title="'.$tmp->name.'" /></span><span class="menu-title">' . $tmp->name . '</span>';


REPLACE WITH


$txt = '<span class="menu-image"><img src="'.JURI::base().'images/stories/'.$iParams->get('menu_image').'" alt="'.$tmp->name.'" title="'.$tmp->name.'" /></span><span class="menu-title">' . $tmp->name . '</span>';


The fix should work perfect on livesite also.
Yupiii, Danny

2 users say Thank You to korb for this useful post

1. rosensta
2. gray

[kappa79 Friend kappa79Join date: March 2009Posts: 30Downloads:0Uploads:3 Thanks: 9]

#323618

In the Blog view, the links at the bottom have a strange label called JPAGE_CURRENT_

---

Attachments:

1. 

[Author]

Posts