Joomla Extensions Club 20,483 posts

[monkeyman Friend monkeymanJoin date: January 2012Posts: 17Downloads:0Uploads:3]

#172486

I’ve played with your component on my friend’s site for several days, banging my head over the wall due to multiple issues. But then decided not to be mad at you for some inconsistencies and help you instead.

First of all, Joomla 1.7 version is very raw. It has a lot of flaws and issues. Here are just a few:

1. Templates are just a mess. Here’s for example how comment form look like:

I’ve tested it in Joomla 1.5 – everything is fine out there. The problem with form in “display: inline-block” in “clearfix” style. I’ve added this for now and it did fix the issue:


#jac-wrapper .form-actions.clearfix,
#jac-wrapper .form-comment.clearfix
{
display: block;
}

Now it looks like it should, but you also have to fix it on your side.

2. Login window in front-end and Preview window in back-end have no styling:

I not sure whether it lack of style declarations of just styling doesn’t being applied, but this Again, in Joomla 1.5 all is perfect.

3. In mail function you have this line, which adds extra breaks:


$mail->setBody(str_replace("n", "<br/>", $content));

Usually this line does extra opposite – it changes <br> tags to n if you have your emails in plain text. But your function takes EVERY line in HTML email and adds extra break after it, so <p>Some text</p> becomes <p>Some text</p><br> and incoming emails look kinda ugly.

4. There’s a check for sending mode in mail function, but no corresponding option in settings:


if ($jacconfig['general']->get('sendmode', 1))
{
$mail->IsHTML(true);
}
else
{
$mail->IsHTML(false);
}


You MUST add an option to choose HTML or plain text mode. This is absolute standard for all mail sending functions. And don’t forget to strip tags, because right now if you force $mail->IsHTML(false), you’ll receive a plain text message with HTML code instead of pure text.

5. English language strings are incorrect. I understand, English is not your native language, so you’ve made a lot of mistakes. I do have to translate it to Russian, but sometimes I don’t even understand the original strings. For example, it took me some time to understand “This email is to inform that your comment on the issue” phrase. “Issue” is not a correct word here – “article” is. Half of strings contain similar mistakes. You really should ask help of native English speakers.

6. One of the CRITICAL issues: your ja.comment.css file overrides main site template’s styles! For example, this killed my list styling:


ul
{
list-style: none outside none;
}


And I really don’t understand why this CSS file is even there – it never being used in comments template, since it has it’s own style.css.

7. Email variables list in back-end contains incorrect items and lacks some. For example, there’s a {CONFIG_SITE_TITLE} variable in the list, which doesn’t work, because {CONFIG.SITE_TITLE} is being used. And {REPLY_OWNER} is not even listed.

8. There’s a daily digest of new comments in email templates, but I didn’t find it’s traces in the code. Looks like it’s never being sent. Have you removed this feature?

9. Relative timestamps all look like “X hours ago”. No seconds, minutes or else.

10. Pages count is incorrect. At the page load it counts ALL comments and creates corresponding number of pages, but when you click any page number, it’ll be recounted WITHOUT replies to comments. For example, I have 24 comments and 10 of them are replies and I chose to show 5 comments per page. On page load JAC will show me 5 pages (24 comments INCLUDING replies), but when I click page 2 or next pages number will decrease to 3 (14 comments EXCLUDING replies).

11. Not sure whether it’s a bug or designed this way, but when you have multiple pages and post a NEW comment (not reply on someone’s comment!), it’ll always be shown at the bottom of every comments page until you reload the main page with article in the browser. I mean, it won’t be just added to the end of comments list, but will remain visible on ALL pages instead.

12. If you have BBCode disabled, you still can Reply with quote, but in this case <blockquote> tag won’t be parsed. For example, I don’t want my visitors to have extra formatting options like bold, italic etc., but replying with quote must be available.

13. If you follow the link to the comment in email, sometimes pagination by 10 comments per page will be automatically turned on, even if you’ve set it to 100 comments per page. Try this: turn on admin approval, post as a registered user, then login as admin and follow the link in New Comment Added email. Or something like this.

14. I think, in libs/dcode.php you have an incorrect link construction:

$strResult = '<a href="'.$url.$item->referer.'" class="comment-quotefrom tonus" target="_blank" title="'.JText::_("Click to see orginal").'"><span>'.JText::_("Quote from").' <strong>'.$strName.'</strong>:</span></a>';

Why it should open in new window? It should be just an anchor without “target” parameter, since it’s just some comment above. Also there’s a call to incorrect language string – should be “Quote_from”, with underscore.

JomSocial related

15. I’m not sure this string is correct, because it displays in JomSocial activity stream as is:

$act->content = JText::_('THIS_IS_THE_BODY');

Looks like you’ve wanted to add a comment content here, but either forgot to do so, or decided not to. Guess, you should change that to $content, add a coresponding variable to JomSocial_addActivityStream function and call it this way:

JACommentHelpers::JomSocial_addActivityStream($user->id, $title, $row->id, $row->comment, $action);

I’ve tried it on my site and it works great. But this REQUIRES a fix described below in #16.

16. If admin approval of comments is turned on, activity stream still being updated immediately. I think it should only be updated after comment has been approved.

17. Quoted comments are being added to activity stream with raw BB-code like this (I had to put extra space in QUOTE tags to avoid parsing by forum engine):

[ QUOTE=Some dude:75]Some test comment.[/QUOTE ] Some test comment.

* * *

But in general you component is very good and this is why I bought it. I really hope you’ll fix all the issues and make it work flawlessly.

---

Attachments:

1. 
2. 

[monkeyman Friend monkeymanJoin date: January 2012Posts: 17Downloads:0Uploads:3]

#433495

Hmm… Not a single answer? Is this component really dead?

[jooservices Friend jooservicesJoin date: October 2014Posts: 8556Downloads:0Uploads:130 Thanked: 1245 times in 1121 posts]

#433497

Hi
Please keep 1 issue / thread than i can try to help you.

Thank you

[monkeyman Friend monkeymanJoin date: January 2012Posts: 17Downloads:0Uploads:3]

#433499

Have you even tried to read through my first post? I wasn’t asking for help in general, I was reporting you numerous issues with JAC in Joomla 1.7. And I really hoped to hear more than “Please keep 1 issue / thread than i can try to help you” as a reply to that.

The only issues I do need help with are pagination related. But it would be nice if you find some time to answer all reported issues. No reason to create gazillion topics for that.

[jooservices Friend jooservicesJoin date: October 2014Posts: 8556Downloads:0Uploads:130 Thanked: 1245 times in 1121 posts]

#433501

Hi
Sorry but yes. More than one issue / thread will make confuse and hard to control / follow up.
With a issue / thread. I would help you raise issue report to dev team. But … multi issues .. I can’t

Thank you for understand.
Viet Vu

[monkeyman Friend monkeymanJoin date: January 2012Posts: 17Downloads:0Uploads:3]

#433503

Yes, it’s mostly developer related, since I’ve fixed most of it for myself. So you’d better pass it to them to check up.

I myself need help with pagination (issues #10 and #13) and #16. These are most annoying.

Also could you tell me, what ITEM_WITH_TITLE_LINK (or something like that) variable should do? It’s a variable for emails and I thought it should add an article title with link to it, but it adds only link.

[jooservices Friend jooservicesJoin date: October 2014Posts: 8556Downloads:0Uploads:130 Thanked: 1245 times in 1121 posts]

#433505

Hi
Please update me with your site URL and backend & ftp access for checking.

Thank you

[monkeyman Friend monkeymanJoin date: January 2012Posts: 17Downloads:0Uploads:3]

#433507

Sure, but I have to create a bunch of dummy comments, so you could do some testing. I’ll create a separate topic for each issue.

Do you have any tracker to report the other ones?

[jooservices Friend jooservicesJoin date: October 2014Posts: 8556Downloads:0Uploads:130 Thanked: 1245 times in 1121 posts]

#433523

Hi
You can use: http://pm.joomlart.com/secure/Dashboard.jspa
As bug report system .

Thank you

[Author]

Posts