test
Viewing 15 posts - 1 through 15 (of 18 total)
  • Author
    Posts
  • bgies Friend
    #174522

    This is the same issue (I think) reported with previous version.

    After upgrading to J 2.5.1, ja_portfolio for J 2.5, using the brown-color in case that makes a difference. Everything else is the default.

    I’ve attached a screenshot of a dummy article (set as featured) that only has the following for content:
    <div style=”height: 200px; background-color: red”></div>

    As you can easily see the Login Module (position : right) is below the content and pushed far to the right

    Sorry the image file is so big, but at least it shows the issue.

    Looking through the generated HTML/CSS and using Firebug to examine it, the issue is that the main <div class=”main clearfix”> extends across the entire page, but does not include the right column. I’ve got the entire page width fixed at 1200px, and the “main clearfix” class extends across all 1200px. The clearfix div does include the main column, but not the right column.

    I can solve the problem by deleting the closing </div> at line 132 of the /plugins/system/jat3/jat3/base-themes/default/page/default.php file, but I’m sure I would be breaking something else.

    To be a little clearer… I’m sure one of the blocks enclosed inside the <div class=”main clearfix”> is outputting an extra end div </div>, but I’m not sure where. Either that, or the <div class=”main clearfix”> .css should not be 1200px wide. The main class includes the width: 1200px. I”m not sure if the main class is intended to include the left/main/right columns or not, but from the indenting in the file it looks like it should only include the main content. If that is the case then the width should be set at the width of the main column only.

    Here is the outline from Firebug :

    <div class=”main clearfix”>
    <div id=”ja-mainbody” style=”width:80%”>
    <!– CONTENT –>
    <div id=”ja-main” style=”width:100%”>
    <div class=”inner clearfix”></div>
    <div id=”system-message-container”></div>
    <div id=”ja-contentwrap” class=”clearfix”>
    <div id=”ja-content” class=”column” style=”width:100%”>
    <div id=”ja-current-content” class=”column” style=”width:100%”>
    <div id=”ja-content-main” class=”ja-content-main clearfix”>
    <h1 class=”componentheading”><span><span>Home</span></span></h1>
    <div class=”blog”>
    <div class=”items-leading”>
    <div class=”leading clearfix”>
    <div class=”contentpaneopen clearfix”>
    <div class=”article-main”></div>
    <div class=”article-content”>
    <div style=”height: 200px; background-color: red”></div>
    </div>
    </div>
    </div>
    <div class=”item-separator”></div>
    </div>
    </div>
    </div>
    </div>
    </div>
    </div>
    </div>
    </div>
    <!– //CONTENT –>
    </div>

    <!– RIGHT COLUMN–>
    <div id=”ja-right” class=”column sidebar” style=”width:20%”>

    Can someone look at this and fix the real issue?

    PLEASE NOTE that installing the quickstart is not an option for this site. But the problem is easily reproducible, so it should be fairly easy for Joomlart to find the problem.


    1. localhost-screen-capture-2012-2-26-11-56-1
    Manos Moderator
    #441326

    Hello,

    Can you please provide us with the code that you have on this article (link given) because it looks like a missing div but the firebug code doesn’t help that much.

    Regards

    bgies Friend
    #441423

    This is the complete code in the article:

    <div style=”height: 200px; background-color: red”></div>

    There is absolutely nothing more in the article. I wanted to make it as simple as possible and still show where the article content is.
    Note that I can fix the problem by adding an opening <div> to the end of the article, or deleting a closing </div> in the template. BUT, I do believe that the <div class=”main clearfix”> is only intended to be 80% width, as by the indentation in the template it looks like it is only intended to enclose the main column.

    I attached the outline because it should show exactly what is enclosed by the <div class=”main clearfix”>, just in case it is a case of having an extra closing div somewhere, or missing an opening div, but the more I look at it, the more I am convinced that the problem is actually that the <div class=”main clearfix”> extends the entire 1200px instead of just 80%.

    Thanks for looking at it.

    <em>@pascm 304484 wrote:</em><blockquote>Hello,

    Can you please provide us with the code that you have on this article (link given) because it looks like a missing div but the firebug code doesn’t help that much.

    Regards</blockquote>

    Phill Moderator
    #441451

    Could you PM me a super admin logon so I can take a look at your article code?

    bgies Friend
    #441524

    <em>@phill luckhurst 304633 wrote:</em><blockquote>Could you PM me a super admin logon so I can take a look at your article code?</blockquote>

    I put this code into a site on my personal machine so I could debug it, so it’s not available on the internet. I was planning on stepping through the code to find out where the extra opening div was coming from, but when I looked at the template and the way it was indented, it seemed the problem is more in the .css file, although I assume the width is set in the code for it also.

    Here’s a screenshot of my article code:

    I should also mention that I can confirm that <div style=”height: 200px; background-color: red”></div> is exactly what is stored in the database for that article


    1. localhost-screen-capture-2012-3-2-15-52-38
    Manos Moderator
    #441583

    Hi,
    Unless i misunderstand something i think that Phill and i were looking for the code to the article that has those divs (ja typography) in.

    bgies Friend
    #441588

    That is 100% of the code in the article, and there is no text. I assumed the problem was in my code at first so I copied the original article and kept removing code until there was nothing left… and the problem remained. That’s why I’m sure the problem is in the Template, or the Framework. There is really nothing else that could be wrong. But, as I’ve said, I’m pretty sure the problem is the width of the that initial <div class=”main clearfix”> which is in /plugins/system/jat3/jat3/base-themes/default/page/default.php file on line 53.

    Do you know where the the width for the “main” class is set? If I could find that, I’m sure I could find the problem.

    FYI. it seems to be specific to ja_portfolio, I don’t have the same issue and cannot duplicate using other templates from joomlart, so that would suggest it’s not the framework.

    Am I not understanding what you mean by “code to the article”?

    Phill Moderator
    #441599

    We would need to know exactly how we can replicate this, what version of Joomla and what other extensions you have installed. We have thousands of users out there using this template and this is the first instance of this we have seen. Without having access to a live copy it is going to be impossible for us to help diagnose your problem.

    bgies Friend
    #441807

    Ok… I’ll start with a fresh install of J 2.5.1 and just add enough to duplicate the problem. Might have it done today

    bgies Friend
    #441993

    Sorry… didn’t get it done yesterday, but here it’s only 8:00 am today, so close.

    I can duplicate the problem (and solve it) by switching the “Show Email Icon” in the “Article Options” of the Home Menu Item. As soon as I switch it to “Hide” I have the problem, and switching it back to “Use Global” fixes it.

    Here’s some better detail. You can clearly see that the broken one is missing the <dl …. > wrapper and has an extra ending div immediately following it. That’s the cause of the problem.

    The broken outline:

    <div class=”contentpaneopen haveimage clearfix”>
    <div class=”article-main”>
    <dd class=”hits”>Hits: 0</dd>
    </div>
    <div class=”article-content”>
    <div style=”height: 200px; background-color: red”></div>
    </div>
    </div>

    The Good outline:

    <div class=”contentpaneopen haveimage clearfix”>
    <div class=”article-main”>
    <div class=”article-tools clearfix”>
    <dl class=”article-info”>
    <dd class=”create”>05 March 2012</dd>
    <dd class=”hits”>Hits: 0</dd>
    </dl>
    <div class=”buttonheading”>
    <span class=”ja-button-email”>
    <a href=”/Joomla_251/index.php/component/mailto/?tmpl=component&template=ja_portfolio&link=3e833e517b76b98862d8731e24e7c684f106d4a6″ title=”Email” onclick=”window.open(this.href,’win2′,’width=400,height=350,menubar=yes,resizable=yes’); return false;”> Email</a>
    </span>
    </div>

    </div>
    <div class=”article-content”>
    <div style=”height: 200px; background-color: red”></div>
    </div>

    </div>

    Phill Moderator
    #442007

    The default setting for our templates quickstart is hide. I think this problem is unique to you and in all likleyhood it is a problem with your articles. I have tried to replicate it on my local system and am unable to. So we would really need to bea able to access your setup to diagnose for you.

    bgies Friend
    #442027

    How can it be a problem with my articles? the only text or code in the article is :

    <div style=”height: 200px; background-color: red”></div>

    Can you point out the problem with that code? Because I sure don’t see it.

    Phill Moderator
    #442030

    As I said, if you cannot provide access to your site then we cannot do much to help. Either that or tell us exactly how to replicate it with our quickstart? I have a copy of the quickstart installed and I have tried but cannot replicate your problem.

    bgies Friend
    #442047

    In post # 10, I showed you almost exactly where the problem is. If I turn the “Show Email Icon” to Hide then this is what I get:

    The <dl….. > wrapper is not there, and there is an extra closing div after the <dd> compared to when the Show Email Icon is set to “Use Global”. The code that produces this is in /templates/ja_portfolio/html/com_content/featured/default_item.php. In post #10 there is also the outline from a working setup (but I didn’t go back and format it nicely).

    The broken outline:

    <div class=”contentpaneopen haveimage clearfix”>
    <div class=”article-main”>
    <dd class=”hits”>Hits: 0</dd>
    </div>
    <div class=”article-content”>
    <div style=”height: 200px; background-color: red”></div>
    </div>
    </div>

    Note that I don’t use the QuickStart because it adds a ton of stuff I don’t want, and it just takes too long to delete it all.

    Phill Moderator
    #442065

    I simply cannot replicate it even if I install the basic template. Maybe one of the other team members can.

Viewing 15 posts - 1 through 15 (of 18 total)

This topic contains 18 replies, has 3 voices, and was last updated by  bgies 12 years, 9 months ago.

We moved to new unified forum. Please post all new support queries in our New Forum