Joomla Extensions Club 20,483 posts

[toymaker Friend toymakerJoin date: April 2010Posts: 123Downloads:0Uploads:5 Thanks: 10 Thanked: 45 times in 32 posts]

#150918

Don’t really know if this was intended but it sure looked weird.

Simptom: When configuring the JA Slideshow parameters and selecting “Combo – Ken Burns Effect” from the Animation Style options, the result is a combined animation that in fact, takes longer than the display of the slide itself.

The file modulesmod_jaslideshowja_slideshowja.slideshow.js shows in line 234 the following code, which results in the effect having a duration equal to the configured Transition duration (check module configuration) + the slide Display Time (check module configuration).


fx = new Fx.Styles(img, {duration: (this.options.duration[0] + this.options.duration[1]),
transition: Fx.Transitions.linear, onComplete: this.complete.bind(this)});


Solution: Replace the code with the following, which will result in the effect having the intended duration, configured inside the module administration page.


fx = new Fx.Styles(img, {duration: (this.options.duration[0]),
transition: Fx.Transitions.linear, onComplete: this.complete.bind(this)});


Optional Fix: The effect is in linear mode, resulting in a sudden stop at the end of the transition/animation, instead of a smooth stop which looks cleaner 😉
If you have Maniacal Obsessive Perfectionism tendencies like me 😀 lol, then use the following code in replacement of the last fix.


fx = new Fx.Styles(img, {duration: (this.options.duration[0]),
transition: Fx.Transitions.quadOut, onComplete: this.complete.bind(this)});


Ok.. now I can go sleep in peace :p
All templates using this module have the same behavior.

Gabriel

[Author]

Posts